-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add hosting of built wheel at PyPI - develop #298
Conversation
preparing for version 2.3 update
Updated docs to address issue with conda install failing
Temporary Fix for NumPy 2.0 Issues (Main Branch)
for automated CDCI with pipit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If it's identical to #297, can't you just merge the main branch into develop?
usually I tend to merge main into develop right before a PR (from develop to main) - does it make more sense to do hot fixes merging one then the other, or does it not matter? |
In terms of the end result, it doesn’t matter. The order only matters for the git history (mainly the merge commit). Ideally, the hot fix should’ve been merged into This is really a style/preference sort of thing. By merging |
Fix AeroForcesCalculator giving forces in wrong frame of reference
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #298 +/- ##
========================================
Coverage 67.70% 67.70%
========================================
Files 166 166
Lines 26710 26734 +24
========================================
+ Hits 18083 18100 +17
- Misses 8627 8634 +7 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Happy for this to be merged if the previous commits are squashed - good addition Kelvin!
Identical to #297 - but merging into develop.