Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hosting of built wheel at PyPI - develop #298

Merged
merged 74 commits into from
Oct 9, 2024
Merged

Add hosting of built wheel at PyPI - develop #298

merged 74 commits into from
Oct 9, 2024

Conversation

kccwing
Copy link
Collaborator

@kccwing kccwing commented Aug 29, 2024

Identical to #297 - but merging into develop.

Copy link
Contributor

@wong-hl wong-hl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it's identical to #297, can't you just merge the main branch into develop?

@kccwing
Copy link
Collaborator Author

kccwing commented Sep 2, 2024

If it's identical to #297, can't you just merge the main branch into develop?

usually I tend to merge main into develop right before a PR (from develop to main) - does it make more sense to do hot fixes merging one then the other, or does it not matter?

@wong-hl
Copy link
Contributor

wong-hl commented Sep 3, 2024

If it's identical to #297, can't you just merge the main branch into develop?

usually I tend to merge main into develop right before a PR (from develop to main) - does it make more sense to do hot fixes merging one then the other, or does it not matter?

In terms of the end result, it doesn’t matter. The order only matters for the git history (mainly the merge commit). Ideally, the hot fix should’ve been merged into dev first, then merge dev into main. But, this is workflow stuff so it makes sense to merge it directly into main.

This is really a style/preference sort of thing. By merging main into dev, you have one less PR and a cleaner git history as the same commits aren’t merged twice.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 96.55172% with 1 line in your changes missing coverage. Please review.

Project coverage is 67.70%. Comparing base (ddff06b) to head (923bbc6).
Report is 84 commits behind head on develop.

Files with missing lines Patch % Lines
sharpy/postproc/aeroforcescalculator.py 96.55% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #298   +/-   ##
========================================
  Coverage    67.70%   67.70%           
========================================
  Files          166      166           
  Lines        26710    26734   +24     
========================================
+ Hits         18083    18100   +17     
- Misses        8627     8634    +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@ben-l-p ben-l-p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy for this to be merged if the previous commits are squashed - good addition Kelvin!

@kccwing kccwing merged commit b1ea255 into develop Oct 9, 2024
10 checks passed
@kccwing
Copy link
Collaborator Author

kccwing commented Oct 9, 2024

Thanks both for the suggestions and reviews, @ben-l-p & @wong-hl!!

@kccwing kccwing deleted the dev_pypi branch October 9, 2024 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants